Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unify the key up/down behaviour of RGB keycodes #15730

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 4, 2022

Description

Not 100% sure why there has to be a difference, as it pushes unnecessary context to intercepting with something like process_record_user.

it seems rather strange to have such a distinction within the codebase, when it doesn't exist for any other keycodes.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 4, 2022 01:02
@tzarc tzarc requested a review from a team January 4, 2022 01:03
@tzarc tzarc merged commit 8dbc8a8 into qmk:develop Jan 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants