Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

move @kakunpc 's keebs into kakunpc/ #15814

Merged
merged 3 commits into from
Jan 12, 2022
Merged

move @kakunpc 's keebs into kakunpc/ #15814

merged 3 commits into from
Jan 12, 2022

Conversation

peepeetee
Copy link
Contributor

Description

image

image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 10, 2022
@peepeetee peepeetee mentioned this pull request Jan 10, 2022
Closed
kakunpc
kakunpc suggested changes Jan 10, 2022
View reviewed changes
keyboards/kakunpc/angel17/readme.md Outdated Show resolved Hide resolved
keyboards/kakunpc/angel64/readme.md Outdated Show resolved Hide resolved
keyboards/kakunpc/suihankey/readme.md Outdated Show resolved Hide resolved
@peepeetee @kakunpc
Apply suggestions from code review
769ad2d 
Co-authored-by: kakunpc <15257475+kakunpc@users.noreply.github.com>
@drashna drashna requested a review from a team January 11, 2022 02:29
fauxpark
fauxpark requested changes Jan 11, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT_FOLDER should be updated to match if/where necessary.

@peepeetee
Copy link
Contributor Author

DEFAULT_FOLDER should be updated to match if/where necessary.

Fixed

@drashna
Copy link
Member

drashna commented Jan 12, 2022

Thanks!

@drashna drashna merged commit 92b2738 into qmk:develop Jan 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@kakunpc kakunpc kakunpc approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peepeetee @drashna @fauxpark @kakunpc