[Core] Add init function to clear previous matrix effect #15815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Jan 10, 2022
tzarc
approved these changes
Jan 16, 2022
sigprof
reviewed
Jan 16, 2022
| @@ -31,6 +31,10 @@ static bool PIXEL_FRACTAL(effect_params_t* params) { | |||
|
|
|||
| inline uint32_t interval(void) { return 3000 / scale16by8(qadd8(rgb_matrix_config.speed, 16), 16); } | |||
|
|
|||
| if (params->init) { | |||
| rgb_matrix_set_color_all(0, 0, 0); | |||
There was a problem hiding this comment.
Hmm, I wonder whether clearing all LEDs like that is the proper behavior here — what if some LEDs are excluded from effect usage by flags?
Although it seems that the DIGITAL_RAIN and TYPING_HEATMAP effects also do the same thing, so maybe that's OK, and flag users just need to be aware that changing the effect may result in clearing the excluded LEDs.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an init function the PIXEL_FRACTAL matrix effect to clear LEDs of previous effect colors on mode change.
Types of Changes
Issues Fixed or Closed by This PR
RGB mode transition bug that was reported by @sigprof on Discord
Checklist