Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

move @omkbd 's boards to /omkbd #16116

Merged
merged 1 commit into from
Feb 1, 2022
Merged

move @omkbd 's boards to /omkbd #16116

merged 1 commit into from
Feb 1, 2022

Conversation

peepeetee
Copy link
Contributor

Description

At this point in my series of board move PRs, I've started to move boards where I cannot reach the makers beforehand, and have to contact them via the PR itself.

This PR is made without contacting(or failing at contacting) @omkbd first, so it would need them to approve it for it to go in.

As there was no prior communication before this PR, I have to ask a few questions:

  • Is the folder name satisfactory?
  • Did I leave anything out?
  • Did I include anything I shouldn't have included?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 29, 2022
@drashna drashna requested a review from a team January 31, 2022 19:50
@drashna drashna merged commit 8515d12 into qmk:develop Feb 1, 2022
yskoht added a commit to yskoht/keymapviz that referenced this pull request Feb 27, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants