Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CLI: Minor additions #12795 #16276

Merged
merged 7 commits into from
Feb 14, 2022
Merged

CLI: Minor additions #12795 #16276

merged 7 commits into from
Feb 14, 2022

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented Feb 8, 2022

Description

Make the output a little bit easier to read and provide more context to the user when the selected keyboard name is already used.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Make the output a little bit easier to read and provide more context to
the user when the selected keyboard name is already used.
@github-actions github-actions bot added cli qmk cli command python labels Feb 8, 2022
@Erovia Erovia requested review from zvecr, tzarc and a team February 8, 2022 19:18
@tzarc
Copy link
Member

tzarc commented Feb 8, 2022

Deferred to next cycle as it's not a bugfix.... unless we decide we want to push it through?

@Erovia
Copy link
Member Author

Erovia commented Feb 8, 2022

Up to you.
These are just the suggestions I wanted to leave on #12795. :)

@Erovia Erovia requested a review from zvecr February 9, 2022 20:14
@peepeetee
Copy link
Contributor

peepeetee commented Feb 14, 2022

Might I suggest having the

provide more context to the user when the selected keyboard name is already used

part of this PR to be merged as a bugfix?

Technically it is a bug, since there should be an error message displayed rather than nothing at all
And it would have helped immensely with my keyboard addition troubleshooting process if said part was included in current develop

@Erovia Erovia merged commit 23c238a into qmk:develop Feb 14, 2022
@Erovia Erovia deleted the cli/new_keyboard2++ branch February 14, 2022 11:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants