Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix idobao/id80/v3 compilation errors #16280

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Fix idobao/id80/v3 compilation errors #16280

merged 2 commits into from
Feb 9, 2022

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Feb 9, 2022

Description

RGB_DI_PIN is redefined
RGBLED_NUM is redefined... looks to be unnecessarily defined anyway.

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 9, 2022 06:58
@zvecr zvecr merged commit d1e5221 into qmk:develop Feb 9, 2022
@waffle87 waffle87 deleted the id80_v3_fix branch February 9, 2022 07:03
@peepeetee
Copy link
Contributor

Thanks! Testing on hardware rn

@peepeetee
Copy link
Contributor

Tested on hardware

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waffle87 @peepeetee @fauxpark @zvecr