Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow NO_PIN within data driven configuration #16359

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 14, 2022

Description

Mostly so that sparse DIRECT_PINS can be correctly configured without having to use a 1xN matrix.

Modifying mcu_pin does however allow other features to be incorrectly configured with NO_PIN. As an alternative solution, a new variant of mcu_pin_array could be introduced so that it limits the change to only matrix config.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Feb 15, 2022
@zvecr zvecr requested a review from a team February 15, 2022 00:48
@tzarc tzarc merged commit fede569 into qmk:develop Feb 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants