Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Drop ALT/CTRL startup issues #16493

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 2, 2022

Description

#15953 changed the behaviour of a few core API. With the arm_atsam code implementing its own main logic, this has introduced #16489.

This PR fixes the use of ISSI driver config before init,

  • matrix_init called twice - the first time way too early compared to other platforms
  • issidrv used before structure configured

Given how the RIOT port has progressed, I didnt see it worth investing a ton of time on the fix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Mar 2, 2022
@zvecr zvecr requested a review from a team March 2, 2022 15:40
@github-actions github-actions bot added the core label Mar 2, 2022
@zvecr zvecr changed the title Fix Drop startup issues Fix Drop ALT/CTRL startup issues Mar 2, 2022
@drashna drashna requested a review from a team March 3, 2022 21:35
@zvecr zvecr merged commit 7fb312c into qmk:master Mar 3, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Drop Alt - QMK configurator generated .bin is bricking the keyboard
2 participants