Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

77b Update expressions #1283

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

michaelhkay
Copy link
Contributor

This PR is the result of splitting PR #832 into two parts; this part extracts update expressions into a separate proposal, for ease of review.

@michaelhkay michaelhkay added XQuery An issue related to XQuery Feature A change that introduces a new feature Tests Needed Tests need to be written or merged labels Jun 17, 2024
@michaelhkay michaelhkay force-pushed the 77b-update-expressions branch from d60990d to 951bd15 Compare June 21, 2024 17:02
ChristianGruen added a commit to qt4cg/qt4tests that referenced this pull request Aug 6, 2024
ChristianGruen added a commit to qt4cg/qt4tests that referenced this pull request Aug 6, 2024
@ChristianGruen ChristianGruen changed the title 77b: Update expressions 77b Update expressions Sep 14, 2024
@michaelhkay michaelhkay force-pushed the 77b-update-expressions branch from 951bd15 to b83dcc1 Compare September 17, 2024 11:55
@michaelhkay michaelhkay added Blocked PR is blocked (has merge conflicts, doesn't format, etc.) labels Sep 17, 2024
@michaelhkay
Copy link
Contributor Author

I have rebased the PR based on the current spec but there are some semantic inconsistencies that need to be ironed out. Known problems: There is a dependency on the selection-path() function which is not in the current spec, and the keywords used for modifiers in lookup expressions have changed.

@ChristianGruen
Copy link
Contributor

In #832 (comment), I made a summary of some changes that I thought would need to be incorporated before map updates can be tackled. I’m copying them to this PR because I was looking them up more than once:

I think we would need a new version of this PR before we can look at #1283. Things I would expect to be added/revised:

  • Singular forms of the keys/values/pairs modifiers.
  • The clarification if we keep item or items, or use content.
  • The note that arrays behave like map with consecutive integer keys.

…and various changes proposed for expressions.xml: https://github.com/qt4cg/qtspecs/pull/832/files#diff-b37a92a9eb3ab9ba48a00de9627a1124466b9c86ecb2b4989d04be3942c597a6

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Blocked PR is blocked (has merge conflicts, doesn't format, etc.) Feature A change that introduces a new feature Tests Needed Tests need to be written or merged XQuery An issue related to XQuery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants