1725 Define more detailed rules for duplicates in maps #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhkay
changed the title
michaelhkay
added
XSLT
| successively to pairs of duplicates. The position in the <xtermref spec="DM40" ref="dt-entry-order"/> | ||
| of the result map of an entry formed by combining duplicates corresponds to the | ||
| position of the first occurrence of the key in the input sequence. This is true | ||
| even whien the option <code>use-last</code> is used: the value of the resulting |
There was a problem hiding this comment.
Suggested change
| even whien the option <code>use-last</code> is used: the value of the resulting | |
| even when the option <code>use-last</code> is used: the value of the resulting |
There was a problem hiding this comment.
- It is nice to have
combineformap:merge. Maybe we should be fully consistent and also add theduplicatesoption tomap:build. - “The key of the combined entry is one of the duplicate keys” → Could we let it always be the first key (as order matters), or is it backward-compatibility that prevents us from doing so?
fn:random-number-generator()...: maybe betterone-of.
|
At meeting 107, the CG agreed to accept this PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the rules for how duplicates are handled by map:merge, map:build, map:of-pairs, and xsl:map.
Introduces a callback option for map:merge that is compatible with map:build and map:of-pairs, to increase commonality between all four functions/instructions.
Fix #1725