A bunch of improvements to logging #3511
Conversation
|
Nice. If you've changed log output to stdout during tests, does that mean we can revert #3359? I don't know if that's enough for the |
|
I don't think it changes the way the logging in the tests works, as that uses a |
|
Don't need to avoid it. It's more a case of wondering whether your change would make that one unnecessary but I suspect it doesn't and we do need to keep the |
This isn't used anywhere, and is redundant in any case because the log size is capped to 10MB and so truncation shouldn't ever be needed.
This sets the logger to either log to stdout (tests/xephyr) or a file, but not both. During regular usage, printing to stdout is pointless. During tests/dev, logging to file is noise (assuming one is within a regular qtile session). This sets the default to stdout to simply its usage (init_log is called much more in tests). This also removes log_color and ties it to stdout so it does print in colour to stdout, but not to log.
It's unlikely anybody is calling this themselves, but it is possibly, so just in case, let's inform users of the change.
This logs exceptions that are risen during Wayland Listener callbacks, which are currently hidden. This requires the new release of pywayland.
This makes all logging calls formatted the same way, such that string interpolation is avoided completely when log messages are below the current log level. This also fixes some log calls where we had two adjacent string literals that were moved onto the same line by black and should instead be merged into one string literal.
|
That pywayland PR was merged so this is ready |
|
LGTM (other than the test failure...) |
|
Great thanks. Those were some orphan imports left in some test files so I've removed those and auto-enabled merge. |
A few miscellaneous changes to logging: