Skip to content

debug order_by field index calculation #24

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

debug order_by field index calculation #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion chsql/src/parquet_ordered_scan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@
if (order_by_column_it == reader->metadata->metadata->schema.end()) {
orderByIdx = -1;
} else {
orderByIdx = order_by_column_it - reader->metadata->metadata->schema.begin() - 1;
orderByIdx = find_if(columnMap.begin(), columnMap.end(),
[&](const int64_t& i) { return i == (order_by_column_it - reader->metadata->metadata->schema.begin() - 1); }) -
columnMap.begin();
}
}
void Scan(ClientContext& ctx) {
Expand Down Expand Up @@ -178,7 +180,7 @@
ParquetOptions po;
po.binary_as_string = true;
set->reader = make_uniq<ParquetReader>(context, file, po, nullptr);
res.push_back(move(set));

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_amd64, x86_64, x64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_amd64, x86_64, x64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_amd64, x86_64, x64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_amd64, x86_64, x64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_amd64, x86_64, x64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_amd64, x86_64, x64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_amd64, x86_64, x64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]

Check warning on line 183 in chsql/src/parquet_ordered_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_amd64, x86_64, x64-osx) 

unqualified call to 'std::move' [-Wunqualified-std-cast-call]
}
}

Expand Down
Loading