Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace @types/rdf-js with @rdfjs/types #167

Closed
jeswr opened this issue Feb 6, 2024 · 4 comments
Closed

Replace @types/rdf-js with @rdfjs/types #167

jeswr opened this issue Feb 6, 2024 · 4 comments

Comments

@jeswr
Copy link

jeswr commented Feb 6, 2024

@types/rdf-js in https://github.com/jacoscaz/quadstore/blob/6e33be85f51230a15128cff61aaa67b0bde265b8/package.json#L76 should be @rdfjs/types instead. See https://github.com/rdfjs/types?tab=readme-ov-file#what-about-typesrdf-js

@jeswr
Copy link
Author

jeswr commented Feb 6, 2024

Impressive turnaround @jacoscaz !

@jacoscaz
Copy link
Collaborator

jacoscaz commented Feb 6, 2024

I was just about to respond @jeswr - lucky coincidence that I was already working on quadstore :)

Thanks for flagging this! I'm making sure that other packages like quadstore-comunica are up to date with this. May I ask you how you came to notice this? Are you using quadstore?

@jeswr
Copy link
Author

jeswr commented Feb 6, 2024

May I ask you how you came to notice this? Are you using quadstore?

I was trying to pin down some warnings that I was getting from components.js building the Community Solid Server so I ran the following search to see what uses of @types/rdf-js were still in use

https://github.com/search?q=%22%5C%22%40types%2Frdf-js%5C%22%3A+%5C%22%22+language%3AJSON&type=code

@jacoscaz
Copy link
Collaborator

jacoscaz commented Feb 6, 2024

Cool stuff! Thanks again @jeswr , this is now on NPM in quadstore@13.0.1 (and quadstore-comunica@4.0.1).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants