-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor QPE bloqs #1297
Merged
Merged
Refactor QPE bloqs #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdmalone
reviewed
Aug 19, 2024
fdmalone
reviewed
Aug 19, 2024
fdmalone
reviewed
Aug 19, 2024
fdmalone
reviewed
Aug 19, 2024
fdmalone
reviewed
Aug 19, 2024
fdmalone
reviewed
Aug 19, 2024
fdmalone
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some nits
woo! 🙌 please let me know if there's anything specific you'd like me to review |
Addressed the changes, added bloq examples, autotests and updates notebooks. Merging now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR does a bunch of long pending refactoring in the phase estimation bloqs. At a high level, the following upgrades are done:
QPEWindowStateBase
is introduced andRectangularWindowState
andLPResourceState
derive from this base class. Helper class methods to determine the number of bits of precision given an epsilon / delta are moved to the window state prep classes since the formulas depend primarily on the window function used.TextbookQPE
andQubitizationQPE
classes now expect an instance ofQPEWindowStateBase
to determine the size of phase register and apply the window state prep unitary.LPResourceState
andLPRSInterimPrep
bloqs are now implemented using Qualtran native decomposition. The tests are updated and LPRSInterimPrep unitary test assumes an incorrect qubit ordering #1068 is fixed.ReflectionUsingPrepare
now supports symbolic bitsizes inbuild_call_graph
, serialization forCZ
basic gate was missing and is now added etc.)