Tensor from classical action #1514
Merged
+212
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpharrigan ptal! |
mpharrigan
reviewed
Jan 24, 2025
| for it when the bloq has a known classical action. | ||
|
|
||
| Examples: | ||
| ``` |
There was a problem hiding this comment.
did you check how this shows up in the docs? does it look ok?
There was a problem hiding this comment.
this didn't work actually, so I removed the Examples:. works now.
There was a problem hiding this comment.
Thank you for checking! (I suspected the "Examples" heading wouldn't work)
| n_qubits_left = sum(left_qubit_counts) | ||
| n_qubits_right = sum(reg.total_bits() for reg in bloq.signature.rights()) | ||
|
|
||
| matrix = np.zeros((2,) * (n_qubits_right + n_qubits_left)) |
There was a problem hiding this comment.
consider adding a check with a helpful error message if n_qubits_right + n_qubits_left is an unreasonably large number
There was a problem hiding this comment.
raises a value error when total > 40
| try: | ||
| matrix = _bloq_to_dense_via_classical_action(bloq) | ||
| except ValueError as e: | ||
| raise ValueError(f"cannot compute tensor: {bloq} is not classical") from e |
There was a problem hiding this comment.
hmm ValueError could potentially come from another source, no? Maybe include the original str(e) message in this error message
mpharrigan
approved these changes
Jan 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my_tensors_from_classical_action: a drop-in replacement forbloq.my_tensorsthat authors of classical bloqs can call, to avoid manually defining the explicit tensor.