-
Notifications
You must be signed in to change notification settings - Fork 126
Add Circuit Generation Notebook for Discrete Time Crystal Experiments #251
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Circuit Generation Notebook for Discrete Time Crystal Experiments #251
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
00204f7
to
066d5dc
Compare
@dstrain115 / @mpharrigan PTAL for method. @XiaoMiQC PTAL for correctness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me modulo some comments.
"import inspect\n", | ||
"from IPython.display import Code\n", | ||
"\n", | ||
"Code(inspect.getsource(time_crystals.symbolic_dtc_circuit_list), language=\"python\")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems weird to me that we are printing out the code as an output of the colab. I'll leave the decision up to you if you stil think this way is clearer, but I would consider linking to the source code with text such as "The code, which can be viewed here (link) is surprisingly succinct."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intent with printing the code was to provide a detailed example of how the circuits are constructed. Perhaps a couple step-by-step examples of each moment for a circuit of a few qubits would be a better example. I'll try this and see how it looks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's kinda neat 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no complaints from me
PR 3 of 6 on implementing and graphing Figures 2d through 3d of Observation of Time-Crystalline Eigenstate Order on a Quantum Processor (arxiv:2107.13571)
This PR adds the notebook which explains the DTC circuit's construction. It depends on PR #250 for the implementation of the circuit constructing function