Skip to content

Add Circuit Generation Notebook for Discrete Time Crystal Experiments #251

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

augustehirth
Copy link
Contributor

@augustehirth augustehirth commented Dec 23, 2021

PR 3 of 6 on implementing and graphing Figures 2d through 3d of Observation of Time-Crystalline Eigenstate Order on a Quantum Processor (arxiv:2107.13571)

This PR adds the notebook which explains the DTC circuit's construction. It depends on PR #250 for the implementation of the circuit constructing function

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@augustehirth augustehirth marked this pull request as draft February 24, 2022 18:58
@augustehirth augustehirth force-pushed the time_crystal_circuit_generation branch from 00204f7 to 066d5dc Compare April 24, 2022 08:19
@dstrain115 dstrain115 self-requested a review May 5, 2022 19:58
@augustehirth augustehirth marked this pull request as ready for review August 22, 2022 17:00
@augustehirth
Copy link
Contributor Author

@dstrain115 / @mpharrigan PTAL for method.

@XiaoMiQC PTAL for correctness.

Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me modulo some comments.

"import inspect\n",
"from IPython.display import Code\n",
"\n",
"Code(inspect.getsource(time_crystals.symbolic_dtc_circuit_list), language=\"python\")"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems weird to me that we are printing out the code as an output of the colab. I'll leave the decision up to you if you stil think this way is clearer, but I would consider linking to the source code with text such as "The code, which can be viewed here (link) is surprisingly succinct."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intent with printing the code was to provide a detailed example of how the circuits are constructed. Perhaps a couple step-by-step examples of each moment for a circuit of a few qubits would be a better example. I'll try this and see how it looks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's kinda neat 🤷

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no complaints from me

@mpharrigan mpharrigan merged commit e7d1b3e into quantumlib:master Aug 23, 2022
@augustehirth augustehirth deleted the time_crystal_circuit_generation branch August 24, 2022 00:11
@augustehirth augustehirth restored the time_crystal_circuit_generation branch August 25, 2023 17:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants