Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make the private key optional in tests #280

Closed
yrodiere opened this issue Apr 13, 2022 · 1 comment · Fixed by #362
Closed

Make the private key optional in tests #280

yrodiere opened this issue Apr 13, 2022 · 1 comment · Fixed by #362
Labels
enhancement New feature or request

Comments

@yrodiere
Copy link
Collaborator

Config property quarkus.github-app.private-key is mandatory, but it's not really useful in dev and test mode AFAICT.

People end up setting it to a dummy private key just to make Quarkus happy.

That's inconvenient. Let's make this configuration property optional in tests and dev mode, if possible?
@gsmet
Copy link
Member

gsmet commented Apr 15, 2022

I had a quick look at that and the private key is required for dev mode.
It can be optional only for tests.

@yrodiere yrodiere added the enhancement New feature or request label May 19, 2022
@yrodiere yrodiere changed the title Make the private key optional in tests and dev mode Make the private key optional in tests Sep 8, 2022
yrodiere added a commit to yrodiere/quarkus-github-app that referenced this issue Sep 8, 2022
@yrodiere
Make the app id and private key optional in tests
685e5b7 
Fixes quarkiverse#280
@yrodiere yrodiere mentioned this issue Sep 8, 2022
Closed
@yrodiere yrodiere mentioned this issue Sep 8, 2022
Merged
@gsmet gsmet closed this as completed in 978708a Sep 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the app id and private key optional in tests yrodiere/quarkus-github-app
2 participants
@yrodiere @gsmet