refactor: Always start devsevices unless a specific URL or port has been specified. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een specified. This closes #299 and I think in the long run, developer experience will be better. Until this change we used any locally running Neo4j instance reachable on 7687. While this is helpful when working on it from other programs, it might not be so helpful in terms of * the general dev experience ("Why doesn't it bring something up, I did not configure it elsewise?") * one doesn't notice it didn't startup anything separate and an integration tests nukes some production data on 7687 The old behaviour can easily be recreated by either specifiying the localhost:7687 Neo4j uri via `quarkus.neo4j.uri` or if this doesn't work for reasons, point the fixed bolt port in devservices to the locally running instance like this `quarkus.neo4j.devservices.bolt-port=7687`. We do consider this a breaking change and will bump the version of Quarkus Neo4j from 4.4 to 5.0, which will be inline with further planned features.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #299 and I think in the long run, developer experience will be better.
Until this change we used any locally running Neo4j instance reachable on 7687.
While this is helpful when working on it from other programs, it might not be so helpful in terms of
The old behaviour can easily be recreated by either specifiying the localhost:7687 Neo4j uri via
quarkus.neo4j.uriorif this doesn't work for reasons, point the fixed bolt port in devservices to the locally running instance like this
quarkus.neo4j.devservices.bolt-port=7687.We do consider this a breaking change and will bump the version of Quarkus Neo4j from 4.4 to 5.0, which will be inline with further planned features.