-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Max frame length of 65536 has been exceeded - Quarkus 3 #43381
Comments
Thanks for reporting. Going forward, all our efforts around WebSockets are focused on WebSockets Next. If you could try and see if the problem exists with that stack, it would be great. cc @mkouba |
Hm, the The corresponding configuration properties in WS Next are |
@geoand ok I'll try. |
Interesting, it was removed (maybe unintentionally) in the "split" PR #7861. In any case, the development of the original WS extension is discontinued. We're looking forward to your feedback about WS next! ;-) |
I have some feedback to give on We are running into the same issue. Our
Yet, we are still seeing the following error on our platform:
I am going to dig into the library now to see where this |
Hi @etiennedv-mathu, the I think that we should add the |
+1 |
Hmmm, are there any workarounds you can think of? |
Yes! You can provide your own |
- add quarkus.websockets-next.server.max-frame-size and quarkus.websockets-next.client.max-frame-size config properties - related to quarkusio#43381 (comment)
@etiennedv-mathu FYI: #46233 |
Thank you very much. |
@mkouba it doesn't look like adding a WebSocketHttpServerOptionsCustomizer has any effect. Heres the
From the logs we can see that even though it sets the MaxWebSocketFrameSize, it has no effect:
|
Sure: For context: This app is is acting as a business logic layer. FerretPlanner is sending this app updates on the lesson model. The exception occurs when this app tries to access lessons that are too big. The initial message includes the entire Lesson model. The following class is where we actually open the web socket.
The following class is a "API" so to speak. it captures the messages and. sends them upwards via the event bus. This is also where the error is happening.
|
Ah ok, so it's a WS next client. In that case, a I've also created #46244 so that it's possible to customize the |
- add quarkus.websockets-next.server.max-frame-size and quarkus.websockets-next.client.max-frame-size config properties - related to quarkusio#43381 (comment) (cherry picked from commit 1f82857)
- add quarkus.websockets-next.server.max-frame-size and quarkus.websockets-next.client.max-frame-size config properties - related to quarkusio#43381 (comment) (cherry picked from commit 1f82857)
Describe the bug
WebSocket Server ignores Max Frame Size after upgrade from Quarkus 1.x to 3.14.4.
In application.properties I set:
quarkus.websocket.max-frame-size=2097152
and get the exception:
Expected behavior
No exception, or a message with my max frame size setting in "Max frame length of 65536 has been exceeded".
Actual behavior
No response
How to Reproduce?
No response
Output of
uname -a
orver
Linux localhost.localdomain 6.4.4-100.fc37.x86_64 #1 SMP PREEMPT_DYNAMIC Wed Jul 19 17:06:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Output of
java -version
openjdk version "21.0.1" 2023-10-17 LTS
Quarkus version or git rev
3.14.4
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.9.6
Additional information
I think this method miss to take the quarkus.websocket.* configuration...
quarkus/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java
Lines 1009 to 1025 in 1c8464b
The text was updated successfully, but these errors were encountered: