Adds redis-devservices it #17133

netodevel · 2021-05-11T00:36:08Z

Adds feature integration tests of redis.devservices
To guarantee the functioning of the resource.

quarkus-bot · 2021-05-11T00:37:37Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `a04cb83`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-05-11T00:41:27Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `86ae778`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Cache Maven Repository`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-05-11T00:44:00Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `7c8f2ca`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

...ts/redis-devservices/src/test/java/io/quarkus/redis/devservices/it/GreetingResourceTest.java

...edis-devservices/src/test/java/io/quarkus/redis/devservices/it/NativeGreetingResourceIT.java

...n-tests/redis-devservices/src/test/java/io/quarkus/redis/devservices/it/utils/SocketKit.java

integration-tests/redis-devservices/src/test/resources/application.properties

...vservices/src/test/java/io/quarkus/redis/devservices/it/DevServicesRedisCustomPortITest.java

...devservices/src/test/java/io/quarkus/redis/devservices/it/DevServicesRedisDisabledITest.java

...-tests/redis-devservices/src/main/java/io/quarkus/redis/devservices/it/GreetingResource.java

machi1990

Wonderful addition. Thanks @netodevel, I left some comments.

netodevel

@machi1990, I made the changes, when I can resolve let me know.

integration-tests/redis-devservices/src/test/resources/application.properties

quarkus-bot · 2021-05-11T13:40:13Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `6ed50d4`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Persist Maven Repo`	⚠️ Check →	Logs	Raw logs

netodevel · 2021-05-12T14:38:00Z

@machi1990, when you can review again

machi1990 · 2021-05-12T14:44:51Z

@machi1990, when you can review again

LGTM. Can you squash, once it is done I'll merge this PR? Thanks for the great work!

netodevel · 2021-05-12T14:59:58Z

@machi1990, when you can review again

LGTM. Can you squash, once it is done I'll merge this PR? Thanks for the great work!

Squash done! Thanks for the review.

machi1990

Thanks for the addition. LGTM.

netodevel · 2021-05-13T14:42:17Z

Thanks for the addition. LGTM.

CI passed, lgtm?
🚀

netodevel · 2021-09-21T19:57:32Z

@machi1990,
I was thinking about adding these integration tests to all other devservices, what do you think?

To do this I would like to reuse this class: https://github.com/quarkusio/quarkus/blob/c5e430c0425895adc97b85df0978617859b4998c/integration-tests/redis-devservices/src/test/java/io/quarkus/redis/devservices/it/utils/SocketKit.java

Which module do you think this class should stay?

geoand requested a review from machi1990 May 11, 2021 07:15