ArC: RequestContext - implement the activity check consistently #38605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is a follow-up of quarkusio#38107
Ladicek
approved these changes
Feb 6, 2024
|
Looks good, but I too am wondering how many tests will break :-) |
manovotn
approved these changes
Feb 6, 2024
What could possibly go wrong when context propagation is involved, right? :) |
Status for workflow
|
|
It's unbelievable but all CI checks passed :-). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, this could break something because previously it was possible to call
RequestContext#destroy()and then still use a client proxy to obtain a contextual reference. Which is obviously wrong but our API docs are not exactly clear in this area 🤷.