Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: allow to skip modal prompt in CI/test environment #654

Merged
merged 6 commits into from
Feb 13, 2025
Merged

feat: allow to skip modal prompt in CI/test environment #654

merged 6 commits into from
Feb 13, 2025

Conversation

mcanouil
Copy link
Contributor

@mcanouil mcanouil commented Feb 8, 2025 •
edited
Loading

In a CI/test environment, the modal prompt for visual mode confirmation is automatically confirmed, streamlining the process.

For reference:

The following precedence logic is implemented:

  • QUARTO_VISUAL_EDITOR_CONFIRMED > PW_TEST > CI

@mcanouil mcanouil marked this pull request as draft February 9, 2025 15:13
@mcanouil mcanouil marked this pull request as ready for review February 9, 2025 15:43
@mcanouil mcanouil marked this pull request as draft February 10, 2025 11:59
@mcanouil mcanouil marked this pull request as ready for review February 11, 2025 20:54
@mcanouil mcanouil changed the title ci: skip modal prompt in CI environment ci: skip modal prompt in CI/test environment Feb 11, 2025
@mcanouil mcanouil changed the title ci: skip modal prompt in CI/test environment feat: allow to skip modal prompt in CI/test environment Feb 11, 2025
midleman
midleman approved these changes Feb 13, 2025
View reviewed changes
Copy link

@midleman midleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from the perspective that this meets our teams needs. Thank you!

@juliasilge juliasilge merged commit 46c6d38 into quarto-dev:main Feb 13, 2025
1 check passed
@mcanouil mcanouil deleted the ci/no-modal branch February 13, 2025 18:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@midleman midleman midleman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcanouil @midleman @juliasilge