Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow password to be shown by default #2591

Merged
merged 2 commits into from
Sep 21, 2018

Conversation

codenamezjames
Copy link
Contributor

@codenamezjames codenamezjames commented Sep 20, 2018

Usage <q-input v-model="user.password" type="password" show-password float-label="Password" />
this change will allow a password field and show/hide icon to be visible by default.

This might be good for an admin panel where you have to make a user account and send that user the credentials.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

codenamezjames and others added 2 commits September 20, 2018 00:01
Usage `<q-input v-model="user.password" type="password" :show-password="true" float-label="Password" />`
this change will allow a password field and show/hide icon to be visible by default.

This might be good for an admin panel where you have to make a user account and send that user the credentials.
@rstoenescu rstoenescu merged commit fd7e06d into quasarframework:dev Sep 21, 2018
@rstoenescu rstoenescu added this to the v0.17.17 milestone Sep 21, 2018
@rstoenescu
Copy link
Member

Thank you for taking time for a PR!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants