Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(docs): QCircularProgress #3000

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

hawkeye64
Copy link
Member

No description provided.

@rstoenescu
Copy link
Member

Hi,

Can you split up the examples by sections pls? This one is too big. Kind of like the Button page.

@hawkeye64
Copy link
Member Author

Can you please look at the following:

  1. Min and Max example: It looks off to me.
  2. No Motion Example: I could not get this to work as expected.

@rstoenescu rstoenescu merged commit 769691b into quasarframework:dev Jan 17, 2019
@rstoenescu
Copy link
Member

Merged so I can more easily see it in action.

@rstoenescu
Copy link
Member

  1. min - max examples --> u're using different min/max and same model
    Some are min=0 - max=50, some are min=50 - max=100... so model is incorrect as it cycles from 0 to 100.

  2. No motion actually works; it jumps to the new value without animation. But there are so many values (100) and the increment is 1 and the cycling happens fast, so it's actually barely noticeable. To notice it, it needs less values (or higher increments), slower cycling.

  3. :show-value="true" --> use short version show-value

@rstoenescu
Copy link
Member

4 . I'd also get rid of the "Interactive" card. Doesn't makes much sense. Devs can click on Codepen link and play with each example already. Plus, on the bad side, to make that example work, you'd need a lot of watchers to normalize different props' values so that they are correct (some may become incorrect, like min/max and model out of range).

@hawkeye64
Copy link
Member Author

Do you want me to fix them and do a new PR?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants