Skip to content

Remove dep on mock #919

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2024
Merged

Remove dep on mock #919

merged 2 commits into from
Sep 6, 2024

Conversation

adamjstewart
Copy link
Collaborator

Let's see if this is still needed or if we can replace this with pytest monkeypatching.

@adamjstewart
Copy link
Collaborator Author

Well that was easy. One fewer dependency to manage.

qubvel
qubvel approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this stale dependency 👍

@adamjstewart adamjstewart merged commit 966bb6d into qubvel-org:main Sep 6, 2024
2 checks passed
@adamjstewart adamjstewart deleted the deps/mock branch September 6, 2024 09:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@qubvel qubvel qubvel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjstewart @qubvel