Skip to content

fix(client): HTTP sender retries send empty request body #38

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix(client): HTTP sender retries send empty request body #38

merged 2 commits into from
Jun 26, 2024

Conversation

puzpuzpuz
Copy link
Collaborator

@puzpuzpuz puzpuzpuz commented Jun 26, 2024 •
edited
Loading

Also changes the following:

  • Buffer is now reset on any network send in Flush calls (explicit and implicit). That's to prevent potential ILP message corruption
  • HTTP sender now sends non-chunked request body

@puzpuzpuz puzpuzpuz added the bug Something isn't working label Jun 26, 2024
@puzpuzpuz puzpuzpuz self-assigned this Jun 26, 2024
@puzpuzpuz puzpuzpuz requested a review from ideoma June 26, 2024 11:02
@puzpuzpuz puzpuzpuz changed the title fix(client): HTTP sender retries were sending empty request body fix(client): HTTP sender retries send empty request body Jun 26, 2024
@puzpuzpuz puzpuzpuz merged commit 38fdfc7 into main Jun 26, 2024
3 checks passed
@puzpuzpuz puzpuzpuz deleted the proper-http-retries branch June 26, 2024 12:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ideoma ideoma ideoma approved these changes

Assignees

@puzpuzpuz puzpuzpuz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puzpuzpuz @ideoma