Skip to content

Enhancement: First field in repeating group as delimiter #674

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 21 commits into from
Jan 27, 2025
Merged

Enhancement: First field in repeating group as delimiter #674

merged 21 commits into from
Jan 27, 2025

Conversation

andreydp
Copy link
Contributor

@andreydp andreydp commented Sep 12, 2023 •
edited by chrjohn
Loading

Fixes #675

@andreydp andreydp mentioned this pull request Sep 12, 2023
Closed
@andreydp andreydp changed the title First field in repeating group as delimiter Enhancement: First field in repeating group as delimiter Sep 12, 2023
@quickfix-j quickfix-j deleted a comment from andreydp Sep 13, 2023
@chrjohn
Copy link
Member

chrjohn commented Sep 13, 2023

Thanks for the PR! 👍
Could you please also add the configuration to the validation section of https://github.com/quickfix-j/quickfixj/blob/master/quickfixj-core/src/main/doc/usermanual/usage/configuration.html

Thanks in advance

@andreydp
Copy link
Contributor Author

Thanks, I've added changes to the documentation and also added session parameter.

chrjohn
chrjohn requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@chrjohn chrjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check my comments. Thank you. :)

@andreydp andreydp requested a review from chrjohn September 18, 2023 10:15
@andreydp
Copy link
Contributor Author

Thanks for the review, pushed changes to the branch.

@noblemaster
Copy link

We are having the same problem with repeating group delimiters. It would be nice to have this merged.

@noblemaster
Copy link

@andreydp We are having the same problem. Would it be OK if I rework your pull request for the new 3.0.0 release? I'll get started beginning of next week in case I don't hear back.

@andreydp
Copy link
Contributor Author

Hi @noblemaster. I can adapt my changes for 3.0.0 release in the next few days.

@noblemaster
Copy link

@andreydp Thanks! I can assist/review as needed. 👍

@andreydp
Copy link
Contributor Author

@noblemaster working on the changes, will push soon, sorry for the delay.

Andrii Poletaiev and others added 3 commits November 29, 2024 10:02
Merge remote-tracking branch 'upstream/master' into first_field_in_gr…
53912e5 
…oup_as_delimiter

# Conflicts:
#	quickfixj-base/src/main/java/quickfix/DataDictionary.java
#	quickfixj-core/src/main/java/quickfix/DefaultSessionFactory.java
#	quickfixj-core/src/test/java/quickfix/DataDictionaryTest.java
@andreydp
Solve merge conflicts. Merge master.
e368c17
@andreydp
Solve merge conflicts. Merge master. Fix tests
7a32f28
@andreydp
Copy link
Contributor Author

@noblemaster I've merged latest master

@noblemaster
Copy link

The change looks good! I have nothing to add. 👍

I would approve it. That's a nice addition. @chrjohn I don't have the powers to approve, so you will have to have a look too. Thanks.

@philipwhiuk
Copy link
Contributor

philipwhiuk commented Dec 3, 2024 •
edited
Loading

Will review tomorrow - have similar stuff in #876 which I'm hoping to work on this month.

chrjohn
chrjohn reviewed Dec 8, 2024
View reviewed changes
Copy link
Member

@chrjohn chrjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature only works when unordered group fields are not validated. Does it make sense to throw an error or generate a warning when this feature is enabled and unordered group fields are validated?
@andreydp @noblemaster @philipwhiuk

@andreydp
Copy link
Contributor Author

I've added a soft warning in createValidationSettings. Please review/merge.

@noblemaster
Copy link

@chrjohn Could you review the changes. Looks generally fine to me.

@chrjohn
moved FirstFieldInGroupIsDelimiter
294d0db 
... to be next to other message/group structure validation option
@chrjohn
Copy link
Member

chrjohn commented Jan 16, 2025 •
edited
Loading

Closing and reopening to trigger github actions which weren't active when this PR was created.
Edit: doesn't seem to work, don't know why Java CI actions are not running...

@chrjohn chrjohn closed this Jan 16, 2025
@chrjohn chrjohn reopened this Jan 16, 2025
@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Jan 16, 2025
@chrjohn
moved FirstFieldInGroupIsDelimiter
61680df 
... to be next to other message/group structure validation options
@chrjohn chrjohn closed this Jan 16, 2025
@chrjohn chrjohn reopened this Jan 16, 2025
@chrjohn chrjohn closed this Jan 16, 2025
@chrjohn chrjohn reopened this Jan 16, 2025
@chrjohn
Copy link
Member

chrjohn commented Jan 16, 2025

Now it is working, don't know why, though.

@noblemaster
Copy link

@andreydp Can you merge your pull request? :)

@chrjohn
Copy link
Member

chrjohn commented Jan 20, 2025

No, he can't. :)
I will do it this week.

@noblemaster
Copy link

Great! Is there a planned v3.0.0 release date as well?

@chrjohn
Copy link
Member

chrjohn commented Jan 20, 2025

2025 🚀 😆
I will really try to do this by end of February the latest. But as I said somewhere else it really would help if I knew of users that are testing their apps with the 3.0.0 snapshot. Unit and acceptance tests are one thing but real life tests are another.

@andreydp
Copy link
Contributor Author

@chrjohn, @noblemaster thank you for review!

@chrjohn
Copy link
Member

chrjohn commented Jan 22, 2025

Again, closing to get all Java CI checks...

@chrjohn chrjohn closed this Jan 22, 2025
@chrjohn chrjohn reopened this Jan 22, 2025
@chrjohn chrjohn merged commit e92a2a3 into quickfix-j:master Jan 27, 2025
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@noblemaster noblemaster noblemaster left review comments

@philipwhiuk philipwhiuk philipwhiuk approved these changes

@chrjohn chrjohn chrjohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
QFJ 3.0.0
Development

Successfully merging this pull request may close these issues.

Ability to set repeating group delimiter dynamically by using first tag of the first group
4 participants
@andreydp @chrjohn @noblemaster @philipwhiuk