Remove sleepycat je #920
Open
Remove sleepycat je #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess #459 wants this to be a separate module. Anyway, I'm just upstreaming what we've done locally at the moment. I can move it to a separate module if that's a blocker. |
Closed
slachiewicz
approved these changes
Jan 23, 2025
the-thing
suggested changes
Jan 23, 2025
There was a problem hiding this comment.
There are still references or details related to sleepycat.
quickfixj-core/src/main/doc/usermanual/usage/acceptor_failover.html
quickfixj-core/src/main/doc/usermanual/installation.html
quickfixj-all/pom.xml
quickfixj-distribution/pom.xml
Possibly more... I think it would be good to remove them.
|
I'm still not sure whether we should remove this or move it to a separate module. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No release of Sleepycat JE since 2018 so probably unmaintained.
From a vulnerability management perspective, if it's still useful I'd rather storage engines with dependencies were separate plugins rather than part of core.