Add column numbers to stack traces #149
Labels
enhancement
New feature or request
Comments
|
For reference this was previously implemented here openwebf/quickjs#12, openwebf/quickjs#1 and some other PRS for quickjs. |
|
Here's the related patch submitted on free-lists https://www.freelists.org/post/quickjs-devel/feat-add-the-column-number-feature-of-Error-Object-and-its-stack |
bnoordhuis
added a commit
to bnoordhuis/quickjs
that referenced
this issue
Dec 9, 2023
And: - display them in stack traces - expose them as Function.prototype.columnNumber OP_line_num is renamed to OP_source_loc and the pc2line data structure is extended with the column number in zigzag encoding. The bytecode version number BC_VERSION is incremented because pc2line data is read and written by JS_ReadObject() and JS_WriteObject() when it is present. Fixes: quickjs-ng#149
bnoordhuis
added a commit
to bnoordhuis/quickjs
that referenced
this issue
Dec 11, 2023
And: - display them in stack traces - expose them as Function.prototype.columnNumber OP_line_num is renamed to OP_source_loc and the pc2line data structure is extended with the column number in zigzag encoding. The bytecode version number BC_VERSION is incremented because pc2line data is read and written by JS_ReadObject() and JS_WriteObject() when it is present. Fixes: quickjs-ng#149
bnoordhuis
added a commit
to bnoordhuis/quickjs
that referenced
this issue
Dec 11, 2023
And: - display them in stack traces - expose them as Function.prototype.columnNumber OP_line_num is renamed to OP_source_loc and the pc2line data structure is extended with the column number in zigzag encoding. The bytecode version number BC_VERSION is incremented because pc2line data is read and written by JS_ReadObject() and JS_WriteObject() when it is present. Fixes: quickjs-ng#149
bnoordhuis
added a commit
that referenced
this issue
Dec 11, 2023
And: - display them in stack traces - expose them as Function.prototype.columnNumber OP_line_num is renamed to OP_source_loc and the pc2line data structure is extended with the column number in zigzag encoding. The bytecode version number BC_VERSION is incremented because pc2line data is read and written by JS_ReadObject() and JS_WriteObject() when it is present. Fixes: #149
bluesky950520
pushed a commit
to bluesky950520/quickjs
that referenced
this issue
Mar 14, 2025
And: - display them in stack traces - expose them as Function.prototype.columnNumber OP_line_num is renamed to OP_source_loc and the pc2line data structure is extended with the column number in zigzag encoding. The bytecode version number BC_VERSION is incremented because pc2line data is read and written by JS_ReadObject() and JS_WriteObject() when it is present. Fixes: quickjs-ng/quickjs#149
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
quickjs currently only records the line number. Also record the column.
Needs (hopefully) minor tweaks to the token parser and the pc2line RLE data structure that's attached to JSFunctionDef and JSFunctionBytecode objects.
Refs: #134 (comment)
The text was updated successfully, but these errors were encountered: