Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

JS_WriteObject does not serialize symbol keys #481

Closed
bnoordhuis opened this issue Aug 18, 2024 · 0 comments · Fixed by #539
Closed

JS_WriteObject does not serialize symbol keys #481

bnoordhuis opened this issue Aug 18, 2024 · 0 comments · Fixed by #539
Labels
bug Something isn't working

Comments

@bnoordhuis
Copy link
Contributor

It doesn't throw an exception, it just silently ignores them:

qjs > new Uint8Array(bjson.write({[Symbol.toStringTag]: "42"}))
Uint8Array(4) [ 12, 0, 8, 0 ]

(8 = object tag, 0 = property count)

Labeling bug because preferably quickjs is taught to (de)serialize them. If that's not feasible, it should probably raise an exception.
@bnoordhuis bnoordhuis added the bug Something isn't working label Aug 18, 2024
saghul added a commit that referenced this issue Sep 21, 2024
@saghul
Add ability to serialize symbol keys in JS_WriteObject
1fa1f9b 
Fixes: #481
saghul added a commit that referenced this issue Sep 21, 2024
@saghul
Add ability to serialize symbol keys in JS_WriteObject
fe4287c 
Fixes: #481
@saghul saghul mentioned this issue Sep 21, 2024
Merged
saghul added a commit that referenced this issue Sep 22, 2024
@saghul
Add ability to (de)serialize symbols
804f588 
Fixes: #481
saghul added a commit that referenced this issue Sep 24, 2024
@saghul
Add ability to (de)serialize symbols
c25aad7 
Fixes: #481
bluesky950520 pushed a commit to bluesky950520/quickjs that referenced this issue Mar 14, 2025
@saghul
Add ability to (de)serialize symbols
1419049 
Fixes: quickjs-ng/quickjs#481
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to (de)serialize symbols quickjs-ng/quickjs
1 participant
@bnoordhuis