Implement RegExp serialization #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS_WriteObject() and JS_ReadObject() now support RegExp objects.
saghul
reviewed
Nov 29, 2023
| JS_WriteString(s, regexp.pattern); | ||
|
|
||
| if (is_be()) | ||
| lre_byte_swap(bc->u.str8, bc->len, /*is_byte_swapped*/FALSE); |
There was a problem hiding this comment.
I'm not sure I follow, why are we calling lre_byte_swap twice, first with false then true?
There was a problem hiding this comment.
is_byte_swapped tells lre_byte_swap whether the size field in the header is in host endianness or not, i.e., whether it needs to byte-swap it. It reads that in order to know how large the bytecode is, because bc->len == header + bytecode + group names.
Why twice? Do and undo: convert from BE to LE, write out data, convert back to BE.
saghul
approved these changes
Nov 29, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS_WriteObject() and JS_ReadObject() now support RegExp objects.