Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sync with upstream #235

Merged
merged 7 commits into from
Dec 22, 2023
Merged

Sync with upstream #235

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0217474
Fix js_strtod with large integers
saghul Dec 22, 2023
5f8308d
Safer typed array finalizer
Dec 22, 2023
edc8036
Add container_of macro
saghul Dec 22, 2023
8d69295
Remove incorrect await in async yield*
saghul Dec 22, 2023
fe56369
Fix: 'for of' expression cannot start with 'async'
saghul Dec 22, 2023
dbba7e4
reduced JS_MAX_LOCAL_VARS (github issue #123)
Dec 22, 2023
b3d5c29
Fix UB in js_dtoa1
saghul Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion quickjs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11110,8 +11110,10 @@ static void js_dtoa1(char (*buf)[JS_DTOA_BUF_SIZE], double d,
} else if (flags == JS_DTOA_VAR_FORMAT) {
int64_t i64;
char buf1[70], *ptr;
if (d > (double)MAX_SAFE_INTEGER || d < (double)-MAX_SAFE_INTEGER)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnoordhuis See past action runs for the error. Let me know what you think of this.

goto generic_conv;
i64 = (int64_t)d;
if (d != i64 || i64 > MAX_SAFE_INTEGER || i64 < -MAX_SAFE_INTEGER)
if (d != i64)
goto generic_conv;
/* fast path for integers */
ptr = i64toa(buf1 + sizeof(buf1), i64, radix);
Expand Down