Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix run-test262 dynamic import #237

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

bnoordhuis
Copy link
Contributor

Dynamic imports should resolve relative to the file under test.

@bnoordhuis bnoordhuis force-pushed the run-test262-dynamic-import branch from cf7c744 to ccc57bf Compare December 27, 2023 00:03
Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

Make basename imports resolve relative to the file under test.
@bnoordhuis bnoordhuis force-pushed the run-test262-dynamic-import branch from ccc57bf to 01f12ed Compare December 27, 2023 09:05
@bnoordhuis bnoordhuis merged commit 64c9ac5 into quickjs-ng:master Dec 27, 2023
@bnoordhuis bnoordhuis deleted the run-test262-dynamic-import branch December 27, 2023 09:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants