-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Add support for compiling with Microsoft Visual Studio C++ (MSVC) #246
Conversation
Thanks for getting this started! Any chance you can add a MSVC target to the CI so it's properly tested? Thank you! |
Sure, I'll add that later |
Also note you can't assume MSVC always if |
Yeah! I already noticed that, should check |
Done, @saghul PTAL |
I re-ran it and it's all good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Left some comments, please take a look!
Co-authored-by: Saúl Ibarra Corretgé <s@saghul.net>
done |
Thank you! |
I built this yesterday and am hoping to put it to use today. Ran into a few things along the way. (Visual Studio 2019, C11 language, and 32-bit build with XP toolset) This also wanted an In Release mode, the I found this post and with its Owing to the 32-bit build it didn't like the Wasn't sure how you'd want to actually handle that (or the previous point) if I did a PR. Also when adding the newly-built library to a project it balked at the I'm including it from a C++ file—default library standard, i.e. C++14—so I figured it was due to the designated initializer (there's even a suggestive comment lower down, above some macros: |
A PR would be most welcome! |
Okay, cool. After I putz around with it a bit I'll get on that. 😄 |
No description provided.