-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: make emscripten works #248
Conversation
Thank you! |
Idn't the output size way too small? |
It is a runtime exception. you can repoduce issues by simple run "console.log(123)". $ emcc -v
emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 3.1.51 (c0c2ca1314672a25699846b4663701bcb6f69cca)
clang version 18.0.0git (https://github.com/llvm/llvm-project f2464ca317bfeeedddb7cbdea3c2c8ec487890bb)
Target: wasm32-unknown-emscripten
Thread model: posix
InstalledDir: /home/henry/demo/emsdk/upstream/bin |
maybe my comments are confused. i am sorry for that. |
That was after your change. Do you think anything is missing? We don't need a comprehensive build, there is quickjs-emacripten for that, we just want to make sure it builds. |
yes, it builds. but could not run directly. |
@saghul how to trigger another rebuild? only one check is failled because network issue. |
Weird, the option to retry is missing. Can you please rebase and force-push? That will trigger a rebuild. |
253c27b
to
55f0bf6
Compare
It seems done. |
sometings changed in emscripten v3.x
let it works.