Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve completion in REPL #343

Merged
merged 3 commits into from
Apr 6, 2024
Merged

Conversation

chqrlie
Copy link
Collaborator

@chqrlie chqrlie commented Apr 4, 2024

  • refine get_context_object to avoid throwing errors (eg: q.)
  • do not call eval in get_context_object to avoid throwing errors and reduce bloat caused by variable closures.

chqrlie added 2 commits April 4, 2024 19:50
- refine `get_context_object` to avoid throwing errors (eg: q.<TAB>)
- do not call `eval` in `get_context_object` to avoid throwing errors
  and reduce bloat caused by variable closures.
- support completion of directives
Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chqrlie chqrlie merged commit fd99929 into quickjs-ng:master Apr 6, 2024
44 checks passed
@chqrlie chqrlie deleted the improve-repl branch April 6, 2024 19:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants