Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix CLI memory stats output #394

Merged
merged 1 commit into from
May 5, 2024
Merged

Fix CLI memory stats output #394

merged 1 commit into from
May 5, 2024

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Apr 22, 2024

No description provided.

@saghul saghul requested a review from chqrlie April 22, 2024 07:34
@saghul
Copy link
Contributor Author

saghul commented Apr 22, 2024

@chqrlie Looks like the qjs -qd option broke when the CLI was refactored with the new dump options.

@chqrlie
Copy link
Collaborator

chqrlie commented Apr 30, 2024 •
edited
Loading

@chqrlie Looks like the qjs -qd option broke when the CLI was refactored with the new dump options.

Actually, I think -qd still works as expected, but not -dq.

PS: sorry for the lag, been busy with complex issues the past 2 weeks

chqrlie
chqrlie requested changes Apr 30, 2024
View reviewed changes
@saghul saghul force-pushed the fix-cli-dump-memory branch from 7cc34f7 to f37b95e Compare May 5, 2024 08:36
@saghul
Copy link
Contributor Author

saghul commented May 5, 2024

@chqrlie Updated, PTAL!

@saghul saghul merged commit 2050bc7 into master May 5, 2024
47 checks passed
@saghul saghul deleted the fix-cli-dump-memory branch May 5, 2024 17:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chqrlie chqrlie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @chqrlie