Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add JS_ArrayGetLength and JS_FreePropertyEnum for external iterators #409

Merged
merged 2 commits into from
May 27, 2024
Merged

Add JS_ArrayGetLength and JS_FreePropertyEnum for external iterators #409

merged 2 commits into from
May 27, 2024

Conversation

Icemic
Copy link
Contributor

@Icemic Icemic commented May 18, 2024

See #408

chqrlie
chqrlie reviewed May 18, 2024
View reviewed changes
@saghul
Copy link
Contributor

saghul commented May 21, 2024

Can you please split this into 2 commits at least? We can keep 1 PR, but the 2 are unrelated.

@Icemic Icemic marked this pull request as ready for review May 23, 2024 15:57
@Icemic
Copy link
Contributor Author

Icemic commented May 23, 2024

Can you please split this into 2 commits at least? We can keep 1 PR, but the 2 are unrelated.

Of course, done

@saghul
Copy link
Contributor

saghul commented May 23, 2024

@chqrlie can you take a quick look at?

@chqrlie
Copy link
Collaborator

chqrlie commented May 23, 2024

@chqrlie can you take a quick look at?

Sometime tonight.

@chqrlie chqrlie merged commit 569f51f into quickjs-ng:master May 27, 2024
47 checks passed
@Icemic Icemic mentioned this pull request Jun 5, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chqrlie chqrlie chqrlie left review comments

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Icemic @saghul @chqrlie