Add 'extern' statements to public headers for C++ compatibility #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Jul 1, 2024
chqrlie
requested changes
Jul 1, 2024
cutils.h
Outdated
Comment on lines
32
to
38
| #ifdef __cplusplus | ||
| extern "C" { | ||
| #endif | ||
|
|
||
| #if defined(_WIN32) | ||
| #include <windows.h> | ||
| #endif |
There was a problem hiding this comment.
I think the #include <windows.h> should be outside the extern "C" block. Unless there is a compelling reason not to, you should move the patch down 4 lines.
chqrlie
approved these changes
Jul 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the
quickjs.handquicks-libc.hhaveextern "C"statements for compiling under C++, this PR adds them to the other public headers