Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable all debug flags when compiling in debug mode #498

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Sep 5, 2024

They still need to be individually enabled either via API or with the -D CLI flag, but there is no need to modify the code and re-compile.

They still need to be individually enabled either via API or with the -D
CLI flag, but there is no need to modify the code and re-compile.
@saghul saghul merged commit 7788436 into master Sep 5, 2024
50 checks passed
@saghul saghul deleted the debug-flags branch September 5, 2024 21:24
@bnoordhuis
Copy link
Contributor

I think this broke something because I now get this when I start qjs:

$ ./build/qjs
js_link_module 'repl.js':
js_inner_module_linking done
js_inner_module_linking done
js_inner_module_linking done
js_inner_module_linking done
js_inner_module_evaluation 'repl.js':
js_inner_module_evaluation 'std':
js_inner_module_evaluation 'os':
js_inner_module_evaluation 'bjson':
QuickJS-ng - Type ".help" for help
qjs > 

@saghul
Copy link
Contributor Author

saghul commented Sep 6, 2024

Oh, I'll take a look!

@saghul
Copy link
Contributor Author

saghul commented Sep 6, 2024

@bnoordhuis Fix: #501

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants