Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Build all Windows targets when building in CI #583

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Build all Windows targets when building in CI #583

merged 2 commits into from
Oct 8, 2024

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Oct 8, 2024

No description provided.

@saghul
Copy link
Contributor Author

saghul commented Oct 8, 2024

LoL it still tries to build run-262, this makes no sense.

D:\a\quickjs\quickjs\run-test262.c(32,1): error C1083: Cannot open include file: 'unistd.h': No such file or directory [D:\a\quickjs\quickjs\build\run-test262.vcxproj]
  quickjs-libc.c
  Generating Code...
D:\a\quickjs\quickjs\quickjs-libc.c(694,1): warning C4702: unreachable code [D:\a\quickjs\quickjs\build\run-test262.vcxproj]

saghul
saghul commented Oct 8, 2024
View reviewed changes
CMakeLists.txt
@@ -284,7 +284,7 @@ endif()
if(WIN32
OR EMSCRIPTEN
OR CMAKE_C_COMPILER_ID STREQUAL "TinyCC"
OR CMAKE_C_COMPILER_ID STREQUAL "GNU" AND CMAKE_C_COMPILER_VERSION VERSION_LESS 5)
OR (CMAKE_C_COMPILER_ID STREQUAL "GNU" AND CMAKE_C_COMPILER_VERSION VERSION_LESS 5))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I think this was the problem with that target being built when it shouldn't! @bnoordhuis

Copy link
Contributor Author

@saghul saghul Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"CMake is (mis)designed to evaluate AND and OR at the same precedence, and from left to right." TIL!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only reasonable response here is 🤦

@saghul saghul requested a review from bnoordhuis October 8, 2024 10:44
@saghul saghul mentioned this pull request Oct 8, 2024
Closed
@saghul saghul merged commit a51c77e into master Oct 8, 2024
52 checks passed
@saghul saghul deleted the windows-ci-simplify branch October 8, 2024 14:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @bnoordhuis