Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove macos-12 buildbots #604

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

bnoordhuis
Copy link
Contributor

GitHub is deprecating and removing them. We also test macos-14 so I opted to remove the buildbots instead of upgrading them to a newer macOS version.

@saghul
Copy link
Contributor

saghul commented Oct 17, 2024

I thint the macOS-14 image it arm64 only. If we want to test x64 too we should add the -large variant IIRC. Other than that, LGTM!

@bnoordhuis
Copy link
Contributor Author

I think the gcc48 buildbot is nearing its end of life, too...

The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH
Error: Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH.

@bnoordhuis
Copy link
Contributor Author

If we want to test x64 too we should add the -large variant

I don't know what that means 😁

@saghul
Copy link
Contributor

saghul commented Oct 17, 2024

If we want to test x64 too we should add the -large variant

I don't know what that means 😁

See: https://github.com/actions/runner-images

macos-14 is arm64 and macos-14-large is x64. macos-12 was x64 (there was no arm64 option for macos 12 IIRC).

@saghul
Copy link
Contributor

saghul commented Oct 17, 2024

I think the gcc48 buildbot is nearing its end of life, too...


The repository will be downloaded using the GitHub REST API

To create a local Git repository instead, add Git 2.18 or higher to the PATH

Error: Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH.

We could always clone in a new runner and run the tests in a container. But if / when it becomes too much hassle: 🪓

@bnoordhuis
Copy link
Contributor Author

macos-14-large: "This job failed", no further explanation

Are large instances a paying customer thing?

@saghul
Copy link
Contributor

saghul commented Oct 20, 2024

macos-14-large: "This job failed", no further explanation

Are large instances a paying customer thing?

Oh could be indeed! We are good then!

GitHub is deprecating and removing them. We also test macos-14 so I
opted to remove the buildbots instead of upgrading them to a newer
macOS version.
@bnoordhuis bnoordhuis merged commit e21d09c into quickjs-ng:master Oct 20, 2024
23 checks passed
@bnoordhuis bnoordhuis deleted the macos-ci branch October 20, 2024 11:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants