-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add C++ compile test #615
Add C++ compile test #615
Conversation
ffs, clang-cl.exe is on the path but cl.exe isn't. I have so many choice words for Windows and msvc. |
bangs head against desk My search engine of choice tells me cl.exe is in ex. @saghul ideas? |
I give up. Towel -> ring. |
I'll take a look, thanks for getting the ball rolling! |
Got it!
|
I suppose we should specify the standard version? |
The fact you need to pull in egor-tensin/vs-shell tells me it's way harder than it should be :-) I'll add a /std: switch and make sure it gets tested with JS_NAN_BOXING on and off. Thanks! |
Check that quickjs.h parses without error when fed to a C++ compiler. Co-authored-by: Saúl Ibarra Corretgé <s@saghul.net>
JS_MKVAL and friends work okay now but the @saghul thoughts? I could drop them from cxxtest.cc and call it a day. For many users it probably works well enough now. It's definitely an improvement over the status quo. (I'll try that out in a separate commit.) |
SGTM! |
Check that quickjs.h parses without error when fed to a C++ compiler.