Don't throw oob exception when setting numeric indexes on TAs #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
LGTM but I would've liked it better if you'd waited until #646 was merged... I don't enjoy fixing merge conflicts.
This should probably come with a regression test, seeing test262 doesn't seem to test for it.
|
SGTM, I'll wait for your PR, apply it on top and add a couple of tests for it! |
|
|
saghul
force-pushed
the
ta-no-throw-oob
branch
from
d847344 to
f84008a
Compare
|
@bnoordhuis Updated, can you PTAL once more? |
Relevant spec section: https://tc39.es/ecma262/multipage/ordinary-and-exotic-objects-behaviours.html#sec-typedarraysetelement It should only throw if Object.defineProperty is used and the TA is detached or OOB if a RAB is used. Fixes: #645
saghul
force-pushed
the
ta-no-throw-oob
branch
from
f84008a to
51395e6
Compare
bnoordhuis
approved these changes
Nov 7, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant spec section: https://tc39.es/ecma262/multipage/ordinary-and-exotic-objects-behaviours.html#sec-typedarraysetelement
It should only throw if the backing buffer is detached, which test262 tests for.
Fixes: #645