Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix exception in WeakRef.prototype.deref #653

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

bnoordhuis
Copy link
Contributor

Set the object's opaque to a sentinel value instead of NULL, to stop JS_GetOpaque2 from raising an "illegal class" exception.

Fixes: #651

Set the object's opaque to a sentinel value instead of NULL, to stop
JS_GetOpaque2 from raising an "illegal class" exception.

Fixes: quickjs-ng#651
@bnoordhuis bnoordhuis merged commit 83fe8f1 into quickjs-ng:master Nov 6, 2024
47 checks passed
@bnoordhuis bnoordhuis deleted the fix651 branch November 6, 2024 21:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WeakRef.deref() should return undefined if value is garbage collected
2 participants