Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Catch error when target executable cannot be found #764

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Catch error when target executable cannot be found #764

merged 1 commit into from
Dec 23, 2024

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Dec 23, 2024

No description provided.

@saghul saghul requested a review from bnoordhuis December 23, 2024 19:00
bnoordhuis
bnoordhuis approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe s/Catch error/Throw error/ because that's what your commit does, right? :)

@saghul
Copy link
Contributor Author

saghul commented Dec 23, 2024

Right 😅

@saghul saghul merged commit e591582 into master Dec 23, 2024
59 checks passed
@saghul saghul deleted the standalone-exe-fix branch December 23, 2024 20:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bnoordhuis bnoordhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @bnoordhuis