Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Exit qjs on unhandled promise rejections #791

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Exit qjs on unhandled promise rejections #791

merged 1 commit into from
Jan 7, 2025

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Jan 6, 2025

Fixes: #790

@saghul saghul mentioned this pull request Jan 6, 2025
Closed
bnoordhuis
bnoordhuis approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the least surprising behavior to me.

@saghul saghul marked this pull request as ready for review January 7, 2025 20:26
@saghul
Copy link
Contributor Author

saghul commented Jan 7, 2025

Let's have it then!

@saghul saghul merged commit 4b8057d into master Jan 7, 2025
59 checks passed
@saghul saghul deleted the exit-on-unhandled-rejection branch January 7, 2025 20:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: Drop the "--unhandled-rejection" CLI flag and exit on unhandled rejections
2 participants
@saghul @bnoordhuis