Add script to create amalgamated build #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the CMake convention how about
Happy to help if you need me to! |
bnoordhuis
commented
Feb 28, 2025
| @@ -124,7 +133,7 @@ jobs: | |||
| - name: get assets | |||
| uses: actions/download-artifact@v4 | |||
| with: | |||
| pattern: qjs-* | |||
| pattern: * | |||
There was a problem hiding this comment.
@saghul is this safe? I really have no idea what I'm doing here.
There was a problem hiding this comment.
It should be fine since we are doing the upload.
There was a problem hiding this comment.
Fingers crossed then!
There was a problem hiding this comment.
Apparently a plain asterisk is invalid syntax? I'm getting CI notifications:
You have an error in your yaml syntax on line 136
Um... suggestions?
There was a problem hiding this comment.
Maybe run the step twice with 2 separate patterns?
saghul
approved these changes
Feb 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your reviewing pleasure:
first commit is Add std.writeFile #932
quickjs-libc is made optional through a
CONFIG_QUICKJS_LIBCdefine, actual name TBDneeds hooking up to the release CI (edit: and should probably be continuously tested)