Add an option to force or wait for commit #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to force a commit or wait for the next commit while issuing an ingest command. This commit only implements it for the ingest endpoint. If all records in the batch fail, the command will hang until at least one good document is indexed until quickwit-oss#2825 is merged in or the document parsing is moved to the early stages. See quickwit-oss#2699
|
@trinity-1686a can you have a look? |
There was a problem hiding this comment.
It would be nice to have an e2e style integration test that ingest a few docs forcing commit and immediately search for them, but that'll possibly be best done once #2984 has been worked on
trinity-1686a
approved these changes
Mar 15, 2023
|
Let's wait for 0.5 release before merging. |
|
As much as release branches can be a pain, the balance of cost vs benefit of having them will only move towards the benefit as the team and customer base grow. Maybe be something to consider for 0.6? |
|
@imotov absolutely, we are releasing tomorrow so we can merge your PR tomorrow. |
|
0.5.0 has been released. I'm going to merge |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an option to force a commit or wait for the next commit while issuing an ingest command. This commit only implements it for the ingest endpoint. If all records in the batch fail, the command will hang until at least one good document is indexed until #2826 is merged in or the document parsing is moved to the early stages.
See #2699
How was this PR tested?
Added tests.