Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor MetastoreError #3752

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Refactor MetastoreError #3752

merged 1 commit into from
Aug 18, 2023

Conversation

guilload
Copy link
Member

Description

  • Move Metastore{Error, Result} to quickwit-proto crate
  • Refactor MetastoreError

How was this PR tested?

make test-all

@guilload guilload requested a review from fmassot August 16, 2023 22:33
@guilload guilload force-pushed the guilload/retry-tower-layer branch from d4d3b24 to 5c84f28 Compare August 17, 2023 16:07
@guilload guilload mentioned this pull request Aug 17, 2023
Merged
6 tasks
Base automatically changed from guilload/retry-tower-layer to main August 17, 2023 16:22
@guilload guilload force-pushed the guilload/move-metastore-error-to-quickwit-proto branch 6 times, most recently from 3f34bed to 3c03132 Compare August 17, 2023 23:52
@guilload guilload enabled auto-merge (squash) August 17, 2023 23:52
@guilload guilload changed the title Move Metastore{Error, Result} to quickwit-proto crate Refactor MetastoreError Aug 17, 2023
@guilload guilload disabled auto-merge August 17, 2023 23:53
@guilload guilload enabled auto-merge (squash) August 17, 2023 23:54
@guilload
Refactor MetastoreError
7041713 
Also move `MetastoreError` and `MetastoreResult` to `quickwit-proto`.
@guilload guilload force-pushed the guilload/move-metastore-error-to-quickwit-proto branch from 3c03132 to 7041713 Compare August 18, 2023 00:34
@guilload guilload merged commit 5341da9 into main Aug 18, 2023
@guilload guilload deleted the guilload/move-metastore-error-to-quickwit-proto branch August 18, 2023 00:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilload @fmassot